Security: Prevent cross-tenant data exposure and credentialed public … - #3
Open
mozluk wants to merge 1 commit into
Open
Security: Prevent cross-tenant data exposure and credentialed public …#3mozluk wants to merge 1 commit into
mozluk wants to merge 1 commit into
Conversation
…fetch This PR secures the live-data fetching endpoint against unauthorized access and data leakage. Previously, the endpoint lacked session validation, utilized wildcard CORS (*), and exposed sensitive user context in API responses, allowing attackers to retrieve user-specific connector data and force server-side fetches. Session Enforcement & Ownership: Added strict session validation (validateSession) to app/api/live/data/[userId]/[slug]/route.ts. The route now mandates that the caller must own the requested data plan (authenticatedUserId === userId). CORS Restriction: Removed Access-Control-Allow-Origin: '*' from the API route headers. CORS is now strictly limited to approved origins defined in ALLOWED_ORIGINS (e.g., the local app origin). Data Masking: Updated lib/live-data-executor.ts to redact the userContext property from the returned DataAPIResponse object, ensuring sensitive configuration data is not leaked to the client.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…fetch
This PR secures the live-data fetching endpoint against unauthorized access and data leakage. Previously, the endpoint lacked session validation, utilized wildcard CORS (*), and exposed sensitive user context in API responses, allowing attackers to retrieve user-specific connector data and force server-side fetches.
Session Enforcement & Ownership: Added strict session validation (validateSession) to app/api/live/data/[userId]/[slug]/route.ts. The route now mandates that the caller must own the requested data plan (authenticatedUserId === userId).
CORS Restriction: Removed Access-Control-Allow-Origin: '*' from the API route headers. CORS is now strictly limited to approved origins defined in ALLOWED_ORIGINS (e.g., the local app origin).
Data Masking: Updated lib/live-data-executor.ts to redact the userContext property from the returned DataAPIResponse object, ensuring sensitive configuration data is not leaked to the client.